Skip to content

fix(ci): minimize Codex review privileges - #20

Merged
Pigbibi merged 1 commit into
mainfrom
codex/minimize-review-secrets-20260710
Jul 10, 2026
Merged

fix(ci): minimize Codex review privileges#20
Pigbibi merged 1 commit into
mainfrom
codex/minimize-review-secrets-20260710

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Restrict the reusable review call to CODEX_AUDIT_SERVICE_URL and isolate legacy gate concurrency by event.

Co-Authored-By: Codex <noreply@openai.com>
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Codex PR Review

Merge allowed: 1 finding(s) reported but none are blocking

ℹ️ Other Findings

1. 🟡 [MEDIUM] Reliability in .github/workflows/codex_review_gate.yml

Changing the concurrency group from just the pull request number to pull_request.number + event_name allows multiple codex_review_gate runs for the same PR to execute at the same time whenever different GitHub event types trigger the workflow. If those runs read or write the same review status, check result, artifact, or PR metadata, they can race and leave the gate in a stale or contradictory state because cancel-in-progress no longer serializes all gate activity per PR. (line 26)

Suggestion: Keep the concurrency key scoped only to the PR (or another single per-PR identifier) unless each event type is guaranteed to operate on completely independent state. If legacy handling needs isolation, use separate workflows or event-specific job names while preserving a single per-PR concurrency group for any shared gate state.


Review by Codex PR Review bot • PR

@Pigbibi
Pigbibi merged commit 928d4f5 into main Jul 10, 2026
4 checks passed
@Pigbibi
Pigbibi deleted the codex/minimize-review-secrets-20260710 branch July 10, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant